Add more state pictograms #1271
Open
+74
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
feature/more-state-pictograms
branch
from
7d04cb3 to
4c6da51
Compare
sukhwinder33445
requested changes
Nov 6, 2025
Comment on lines
344
to
376
| if ($icon === null) { | ||
| if (! $item->notifications_enabled) { | ||
| $icon = new Icon(Icons::NO_NOTIFICATIONS, ['title' => $this->translate('Notifications disabled')]); | ||
| } elseif (! $item->active_checks_enabled) { | ||
| $icon = new Icon(Icons::NO_ACTIVE_CHECKS, ['title' => $this->translate('Active checks disabled')]); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
These icons are still missing in the specific column view list (e.g., URL: icingadb/hosts?columns=name). These should be added to the State::getIcon() method to cover all use cases.
Contributor
Author
There was a problem hiding this comment.
The columns notifications_disabled and active_checks_disabled do not come from the state, but the corresponding host/service item. Would you still add this to State::getIcon()?
Contributor
Author
There was a problem hiding this comment.
I would rather add the logic to StateRowItem::assembleVisual() directly to access the item's columns.
jrauh01
force-pushed
the
feature/state-pictogram-tooltips
branch
from
6a39bfc to
428345d
Compare
jrauh01
force-pushed
the
feature/more-state-pictograms
branch
from
4c6da51 to
ce7f0d2
Compare
jrauh01
force-pushed
the
feature/more-state-pictograms
branch
from
ce7f0d2 to
e10c9f4
Compare
jrauh01
force-pushed
the
feature/state-pictogram-tooltips
branch
3 times, most recently
from
b7126c6 to
541ce9b
Compare
Now also add pictograms to state ball in the following cases: - Disabled active checks - Disabled notifications
jrauh01
force-pushed
the
feature/more-state-pictograms
branch
from
e10c9f4 to
543c756
Compare
sukhwinder33445
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now also add pictograms to state ball in the following cases:
If both active checks and notifications are disabled, the “notifications disabled” icon is shown. This is because results may still arrive from passive checks, but they cannot trigger notifications when notifications are disabled.
Resolves #1097